-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx-plugin): correct importPath and import updates for migration to local plugins #16437
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
AgentEnder:fix/address-some-issues-in-workspace-plugin-migration
Apr 20, 2023
Merged
fix(nx-plugin): correct importPath and import updates for migration to local plugins #16437
FrozenPandaz
merged 1 commit into
nrwl:master
from
AgentEnder:fix/address-some-issues-in-workspace-plugin-migration
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/address-some-issues-in-workspace-plugin-migration
branch
from
April 20, 2023 16:53
2a52122
to
29dc8cb
Compare
AgentEnder
requested review from
bcabanes,
isaacplmann and
juristr
as code owners
April 20, 2023 16:53
AgentEnder
force-pushed
the
fix/address-some-issues-in-workspace-plugin-migration
branch
from
April 20, 2023 16:58
29dc8cb
to
5619255
Compare
bcabanes
approved these changes
Apr 20, 2023
FrozenPandaz
requested changes
Apr 20, 2023
packages/workspace/src/migrations/update-16-0-0/move-workspace-generators-to-local-plugin.ts
Show resolved
Hide resolved
AgentEnder
force-pushed
the
fix/address-some-issues-in-workspace-plugin-migration
branch
from
April 20, 2023 17:32
5619255
to
b7b6141
Compare
FrozenPandaz
approved these changes
Apr 20, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
tools
folder, their import paths would be broken${npmScope}/workspace-plugin
Expected Behavior
tools
folder, their import paths are not broken@${npmScope}/workspace-plugin
--name
to converted generatorsRelated Issue(s)
Fixes #